Skip to content

Scope support tree view #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 36 commits into from
Closed

Scope support tree view #1663

wants to merge 36 commits into from

Conversation

@pokey
Copy link
Member

@pokey pokey commented Jul 20, 2023 •
edited
Loading

image

Checklist

  • File follow-up issue to use the language icon for language-specific scopes
  • Add tests for talon side. Use context to set csv overrides dir setting to tmp dir, then override spokenforms json output location, then call the update function. Check output, then tweak csv, then check output again
  • I have added tests
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet
  • Add buttons to visualize scope, removal range, and iteration scope (if it's supported and present)
  • Indicate which ones contain your selections in their domain?
  • Rename view to just cursorless.scopes, and change title
  • Change section titles to be "present", "supported", "legacy", and "unsupported"
  • What to do when we add a new scope type? See TODO comment. update: let's detect that it's not in the json, and report that they need to update
  • Click on visualized scope to deactivate scope visualizer
  • Indicate which scope is being visualized
  • Other things from tree provider / tree item api that we want to support?
  • Voice command to show tree view
  • Where to put the tree view? Currently in explorer sidebar
  • Click on scope to show scope visualizer
  • Add hover (alternate spoken forms?)
  • Move - entries to the end (maybe in own section?)
  • Add tooltip with alternate spoken forms
  • Fix custom regex
  • Add test for custom regex generate spoken form
  • Place language-specific scopes at the top. Have sub-levels for lang-specific vs global? Collapse global by default? Use icon to indicate whether global or lang-specific. Just use the icon for the current language. For global, either use globe or something, or just no icon at all
  • Add entries for other complex scope types? (eg custom regex?)
  • Add icons
  • Use spoken forms from ~/.cursorless/spoken.json, falling back to defaults
  • Add entries for surrounding pairs

@pokey pokey force-pushed the pokey/scope-support-tree-view branch from 1973dba to 35ec0cd Compare July 20, 2023 16:19
AndreasArvidsson
AndreasArvidsson reviewed Aug 3, 2023
View reviewed changes
@pokey pokey force-pushed the pokey/scope-support-tree-view branch 5 times, most recently from 9b9e6ff to 785791c Compare August 17, 2023 00:26
@pokey pokey changed the base branch from main to pokey/query-hot-reloading-during-development August 17, 2023 00:30
@pokey pokey mentioned this pull request Aug 17, 2023
Merged
3 tasks
@pokey pokey force-pushed the pokey/scope-support-tree-view branch from 785791c to 457dc0a Compare August 17, 2023 00:49
@pokey pokey force-pushed the pokey/query-hot-reloading-during-development branch from 772b512 to c03c303 Compare August 17, 2023 00:49
github-merge-queue bot pushed a commit that referenced this pull request Aug 18, 2023
@pokey
Add generic file watcher api (#1802)
c10b417 
- Required by #1803
- Required by #1663

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey pokey force-pushed the pokey/query-hot-reloading-during-development branch from c03c303 to f640f98 Compare August 18, 2023 13:22
@pokey pokey force-pushed the pokey/scope-support-tree-view branch from 457dc0a to f1d190a Compare August 18, 2023 13:22
Base automatically changed from pokey/query-hot-reloading-during-development to main August 18, 2023 13:53
@pokey pokey force-pushed the pokey/scope-support-tree-view branch 6 times, most recently from 4dd5dd0 to 97611cc Compare August 23, 2023 14:53
@pokey pokey force-pushed the pokey/scope-support-tree-view branch 2 times, most recently from 5eaf08c to 49b85de Compare September 29, 2023 19:00
@pokey pokey added the to discuss Plan to discuss at meet-up label Sep 29, 2023
@pokey pokey force-pushed the pokey/scope-support-tree-view branch from 39113c7 to fbb31f1 Compare October 3, 2023 15:01
@pokey pokey removed the to discuss Plan to discuss at meet-up label Oct 3, 2023
@pokey
Copy link
Member Author

pokey commented Oct 5, 2023

update from meet-up:

  • Have our own cursorless sidebar which shows icon
  • spoken form is "bar cursorless", which focuses cursorless sidebar
  • use code icon for now

auscompgeek
auscompgeek reviewed Oct 5, 2023
View reviewed changes
@pokey pokey force-pushed the pokey/scope-support-tree-view branch from fcf9e97 to 7db33c6 Compare October 6, 2023 16:12
@pokey pokey force-pushed the pokey/scope-support-tree-view branch from ff3daf4 to 357e57d Compare October 12, 2023 14:47
@pokey pokey mentioned this pull request Oct 25, 2023
Merged
6 tasks
@pokey
Copy link
Member Author

pokey commented Oct 27, 2023 •
edited
Loading

Split into multiple PRs:

@pokey pokey closed this Oct 27, 2023
@pokey pokey deleted the pokey/scope-support-tree-view branch October 27, 2023 11:00
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Cursorless scope side bar (#1942)
1260235 
- Depends on #1941
- Depends on #1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original #1663
cursorless-bot pushed a commit that referenced this pull request Oct 30, 2023
@pokey
Cursorless scope side bar (#1942)
bbc33e0 
- Depends on #1941
- Depends on #1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original #1663
fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Cursorless scope side bar (cursorless-dev#1942)
df785cc 
- Depends on cursorless-dev#1941
- Depends on cursorless-dev#1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original cursorless-dev#1663
thetomcraig-aya pushed a commit to thetomcraig/cursorless that referenced this pull request Mar 27, 2024
@pokey @cursorless-bot
Cursorless scope side bar (cursorless-dev#1942)
6c946c3 
- Depends on cursorless-dev#1941
- Depends on cursorless-dev#1946

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
(see comment below)
- [x] Add descriptions to section headings (eg present, not present,
etc)
- [x] File issue about using lang icons for lang-specific scopes
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
- [x] File issue for showing scopes touching, as well as equal to,
selection
- [x] Checkboxes from original cursorless-dev#1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auscompgeek auscompgeek auscompgeek left review comments

@AndreasArvidsson AndreasArvidsson AndreasArvidsson left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pokey @auscompgeek @AndreasArvidsson